-
Notifications
You must be signed in to change notification settings - Fork 2k
python
: add 3.13
support
#3180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
python
: add 3.13
support
#3180
Conversation
a483a9d
to
24d1da9
Compare
24d1da9
to
5fe5697
Compare
6c99220
to
d54d5a7
Compare
b6b3a8e
to
954da58
Compare
dc86b9e
to
308d126
Compare
fc5223d
to
ecb34a7
Compare
ecb34a7
to
7cb4f3f
Compare
7cb4f3f
to
38682dc
Compare
This PR is ready for review. I have tested python |
version = '3.11.5' | ||
name = 'hostpython3' | ||
version = '3.11.13' | ||
_p_version = Version(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest create it directly where it is used otherwise it wont use the instantiated version value.
@property | ||
def site_dir(self): | ||
dir = None | ||
dir = f"usr/local/lib/python{self._p_version.major}.{self._p_version.minor}/site-packages/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is using the default version, but we need the instantiated one.
p_version = Version(self.version)
dir = f"usr/local/lib/python{p_version.major}.{p_version.minor}/site-packages/"
This PR adds python
3.13
support, we can't set default version to3.13
just yet as in latest python,distutils
was removed, so a lot of recipes need updating.